ratatui-org / ratatui

Rust library that's all about cooking up terminal user interfaces (TUIs) 👨‍🍳🐀
https://ratatui.rs
MIT License
8.82k stars 263 forks source link

Bug: ensure that block title rows apply the border style #1185

Open joshka opened 2 weeks ago

joshka commented 2 weeks ago

Maybe we should enforce an empty border when a title is defined, but no border is explicitly defined? Sounds like a bug that should be fixed internally rather than adding a workaround for external use?

_Originally posted by @EdJoPaTo in https://github.com/ratatui-org/ratatui/pull/1182#discussion_r1642510885_

I'm not 100% certain whether the current behavior is the right behavior here. To me there's a bit of ambiguity - titles generally occupy the space that would be bordered, but when there isn't a border defined, or the top/bottom border is not enabled, then I'm not sure that the border style should be used.