Open joshka opened 6 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.4%. Comparing base (
3f2f2cd
) to head (5f4e508
). Report is 10 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Cool idea! LGTM! Curious what other people think.
@EdJoPaTo ?
This simplifies the rendering but I'm not sure how useful it actually might be. Ideally the same Render Widget or whatever its named trait should exist here too I think? That would reduce the differences. Especially as a context is of interest anyway and Frame would reduce the need for the context too. And the current trait doesn't allow for a Result currently either? Not sure what the ideal way would be.
I regularly find myself using methods which return results and having to throw away the possible errors inside of the draw method by either crashing or ignoring them. This would make it possible to add more context to the errors (using anyhow / eyre), and have the app more gracefully crash.
This is a first point in making some of these future things more useful. We don't need to solve the entire problem, but this is a piece that is fine and necessary on its own.
This makes it easier to write fallible rendering methods that can use the
?
operator