search

ratatui-org / ratatui

Rust library that's all about cooking up terminal user interfaces (TUIs) 👨‍🍳🐀
https://ratatui.rs
MIT License
8.82k stars 263 forks source link

fix: ScrollbarOrientation should probably be Copy too. #1213

Open thscharler opened 5 days ago

thscharler commented 5 days ago

This seems to be some oversight, and is just slightly annoying to use.

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.4%. Comparing base (60bd7f4) to head (8484d0b). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1213 +/- ## ===================================== Coverage 94.4% 94.4% ===================================== Files 62 62 Lines 15048 15048 ===================================== Hits 14217 14217 Misses 831 831 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joshka commented 5 days ago

This introduces a couple of clippy errors where this is passed as a reference. Fixing that wil be a breaking change (which we document, etc.) As we've just released 0.27.0, there might be some time until this gets merged. I'd suggest slapping an allow attribute for the lint on the broken code now and come back and fix those later before 0.28.0. Alternatively leave this until closer to 0.28.0 and do both at once.