search

ratatui / ratatui-macros

Macros for simplifying boilerplate for creating UI using Ratatui.
https://ratatui.rs
MIT License
24 stars 2 forks source link

feat: Add fill constraint #34

Closed kdheepak closed 4 months ago

joshka commented 4 months ago

I'm not a fan at all of this particular macro as it feels like "too much magic" to me, so I have no opinion on merging this.

EdJoPaTo commented 4 months ago

I'm not a fan at all of this particular macro as it feels like "too much magic" to me, so I have no opinion on merging this.

In general, I also avoid using Layout in the first place. Its logic is too complicated and writing that math myself is short enough so I never wanted to care about that Layout magic.

There is simply too much going on for my taste. So I neither use layout nor would use this macro.

kdheepak commented 4 months ago

I just wanted the macro to support all of the constraints for completeness sake. There appears to be just one user in the wild at the moment. We can leave this macro in this crate.

I will plan on making a PR for span! and line! to the core crate.