search

ratbuddy / ratbuddyssey

Audyssey .ady file editor
MIT License
92 stars 25 forks source link

Crash in version 0.2.1 #2

Closed sramsay100 closed 4 years ago

sramsay100 commented 5 years ago

Many thanks for your hard work. I haven’t fully tried this app yet but it is a must considering the vast lack of functionality of the Audyssey App.

I would like to report that when you select a measurement to be displayed on the graph that doesn't exist, the app crashes. My ADY file contains 3 measurements (the bare minimum the app allows you to take) and when clicking on measurement 4, it app crashes and exits.

Sofa Forward Solo.zip

May I suggest a simple IF statement that detects the number of measurements and ghosts/disables the selectable check boxes in UI for those which aren’t available. A small bug nonetheless, one that can easily be fixed if you has time. Hope this helps.

ratbuddy commented 5 years ago

I will look at this, thank you.

sramsay100 commented 5 years ago

Hi RatBuddy. I would like to contribute more to say thank you for a great little App. I have found it really useful so far. I have found five more small bugs which I think would be a really simple and quick fix for you to recode. One of them makes a huge difference for me and I personally believe it fills in a huge hole in the Editor App for those looking to edit a flat target curve instead of reference one.

I'm happy to debug to find the solution for you before commenting here in 'Issues', if this helps at all. Unless you prefer me to message you directly somehow?

Look forward to hearing back from you on this.

Steve

ratbuddy commented 5 years ago

Whatever you prefer.. if you want to go ahead and fix anything, I will be happy to review any pull requests as well.

On Mon, May 6, 2019, 7:00 PM Steve Ramsay notifications@github.com wrote:

Hi RatBuddy. I would like to contribute more to say thank you for a great little App. I have found it really useful so far. I have found five more small bugs which I think would be a really simple and quick fix for you to recode. One of them makes a huge difference for me and I personally believe it fills in a huge hole in the Editor App for those looking to edit a flat target curve instead of reference one.

I'm happy to debug to find the solution for you before commenting here in 'Issues', if this helps at all. Unless you prefer me to message you directly somehow?

Look forward to hearing back from you on this.

Steve

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ratbuddy/ratbuddyssey/issues/2#issuecomment-489817669, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMDUGUHHJI5JOEVYMG7F7DPUC2AFANCNFSM4HK3ZTAA .

sramsay100 commented 5 years ago

Sorry buddy I meant to mention that I haven’t coded with C# in over a decade and don’t have the confidence to recode your work. If however, this is the only contribution you are looking for then then I understand as I agree that GitHub is designed for contributions from developers.

ratbuddy commented 5 years ago

Not at all, I just wanted to let you know that any help is welcomed, whether it be reporting bugs, testing, coding, or just plain suggestions. I'm not picky or proud :)

On Mon, May 6, 2019, 7:04 PM Steve Ramsay notifications@github.com wrote:

Sorry buddy I meant to mention that I haven’t coded with C# in over a decade and don’t have the confidence to recode your work. If however, this is the only contribution you are looking for then then I understand as I agree that GitHub is designed for contributions from developers.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ratbuddy/ratbuddyssey/issues/2#issuecomment-489818673, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMDUGXQDDGJ4IZKSP7ISZLPUC2RTANCNFSM4HK3ZTAA .