search

ratcashdev / authenticroast

Automatically exported from code.google.com/p/authenticroast
1 stars 0 forks source link

DelegatingAuthenticator calls abstract method in constructor #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
DelegatingAuthenticator calls the abstract method createAuthenticators() in its 
constructor. This is generally considered to be poor practice as the derived 
class is only half-constructed at this point. In my case it caused an NPE 
trying to log the created authenticators or indeed log any exceptions while 
creating them. The createAuthenticators() method should be called lazily when 
the result is needed.

Original issue reported on code.google.com by EsmondP...@gmail.com on 8 Nov 2010 at 11:20

GoogleCodeExporter commented 9 years ago 
You are right, fixed in trunk.

Original comment by aike.som...@gmail.com on 9 Nov 2010 at 9:27