ratcashdev / authenticroast

Automatically exported from code.google.com/p/authenticroast
1 stars 0 forks source link

Nobody calls LogoutManager.onLogout()? #8

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The method is there to be overridden but nobody calls it that I can see.

Surely this:

        if (logoutAction) {
            manager.forward(request, getNextPath(manager, request));
            return ManageAction.Clear;
        }

should be:

        if (logoutAction) {
            onLogout(manager, request);  // <======
            manager.forward(request, getNextPath(manager, request));
            return ManageAction.Clear;
        }

???

Also it should be clarified that this is called *before* the session is 
destroyed.

EJP

Original issue reported on code.google.com by EsmondP...@gmail.com on 16 Nov 2010 at 3:48

GoogleCodeExporter commented 9 years ago
Asolutely. Fixed. :-)

Original comment by aike.som...@gmail.com on 16 Nov 2010 at 9:03