search

ratchetphp / RFC6455

I/O agnostic WebSocket Protocol
MIT License
218 stars 38 forks source link

Replace Guzzle based request/response object with PSR-17 factory #34

Open taavit opened 5 years ago

taavit commented 5 years ago

Current implementation is based on Guzzle PSR-7 implementation. This might lead to have multiple PSR-7 implementation across project (I'm using zend-diactoros in my project). While this is not a big problem, using one implementation across whole project (including libraries) and single request/response factory should make dependency tree smaller.

cboden commented 4 years ago

Awesome, I like it! Could you rebase against master please?

taavit commented 4 years ago

Tests failed due to tested php versions. (guzzle requires php ^7.2, nyholm/psr7 ^7.1, diactoros ^7.1) I could switch to laminas/nyholm factories, so this should pass 7.1 as well.

cboden commented 4 years ago

Are there no factory implementations that support older versions?

taavit commented 4 years ago

psr/http-factory itself requires php 7.0+. For php 7.0 I found only this: https://packagist.org/packages/php-extended/php-http-message-factory-psr17

cboden commented 4 years ago

Ok. We're likely doing one more release then dropping support for PHP5 and lower versions of 7. I'll circle back to this PR shortly.