Open bacnguyen opened 7 years ago
@ninksink
I've made the changes. Please make the changes, let me know I will do the ISO test.
@bacnguyen Ok, https://dev.ratecount.com is available now on branch issue-2
ubuntu@server-01:/var/www/dev.ratecount.com/public_html$ git status
On branch issue-2
Your branch is up-to-date with 'origin/issue-2'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
modified: composer.lock
modified: config/app.php
composer.lock
and app.php
contain changes that occur when we have to run "composer update".
Those changes are completely normal
@ninksink
Tested out the webpage. Two issues that I found:
Issue 1: On desktop - its working correctly but on the mobile Nexus 6 and Iphone 6S and 6S Plus, responsive not working correctly but on desktop using Chrome browser developer tool to stimulate mobile dev, it rendering correctly. See attached:
Issue 2:
When going to https://dev.ratecount.com, a popup ask "dev.ratecount.com wants to: know your location". I click yes, enter zip code - no Google autocomplete down drop.
@ninksink
In regards to Issue 1, I commented out
<meta name="viewport" content="width=device-width, initial-scale=1">
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
I will do another release of the update. Rookie mistakes.
@ninksink
Close this as the code is working as expected. Will create an issue about the responsive design.
update html and css to load faster and fix format