search

ratel-rust / ratel-core

High performance JavaScript to JavaScript compiler with a Rust core
Apache License 2.0
435 stars 17 forks source link

Fix computed member access not treated as lvalue #116

Closed ishitatsuyuki closed 5 years ago

ishitatsuyuki commented 5 years ago

Close #108 Close #114

ishitatsuyuki commented 5 years ago

Question: should we avoid the match wildcard (_) to avoid mistakes like this?

maciejhirsz commented 5 years ago

Question: should we avoid the match wildcard (_) to avoid mistakes like this?

I think as far as AST is concerned the wildcard is okay, since adding new variants to AST types is a pretty rare occurrence and should introduce new tests, but I'm open to be convinced otherwise.