Add clippy - Githubissues

ratel-rust / ratel-core

High performance JavaScript to JavaScript compiler with a Rust core

Apache License 2.0

435 stars 17 forks source link

Add clippy #90

Closed pitaj closed 6 years ago

pitaj commented 6 years ago

Partial fix for #20

Add clippy to tests
Bring code in line with clippy
Add TODOs and disable warnings for clippy issues that appear to be bugs or unfixable without big changes

rustfmt changes the alignment of arrows in matches among other things, and there is no way to disable or configure this as far as I could tell. So at the moment, fmt will have to wait.

pitaj commented 6 years ago

Are there any other concerns with this?

pitaj commented 6 years ago

Humpty dumpy
Rumpty bumpty

ishitatsuyuki commented 6 years ago

The maintainers are not really active. It's good to ping them periodically, but otherwise we probably have to wait patiently.

pitaj commented 6 years ago

Bump