ratel-rust / ratel-core

High performance JavaScript to JavaScript compiler with a Rust core
Apache License 2.0
435 stars 17 forks source link

Refactor visitors and transformers #91

Closed ishitatsuyuki closed 6 years ago

ishitatsuyuki commented 6 years ago

Visitors: switch to a more commonly used model. Projects like serde or rustc are examples.

Transformers: self-explanatory additions to revive the transform(Module) entrypoint. Some tautological tests are removed.

ParentTrackingContext: removed because the usage is unknown.

ishitatsuyuki commented 6 years ago

@cmtt Review ping!

maciejhirsz commented 6 years ago

@ishitatsuyuki hey, sorry for being quiet here, I'll review this whenever I have a moment!

maciejhirsz commented 6 years ago

Btw, given how clean this PR was and how long you waited, if you would like, I'd be more than happy to add you to maintainers!

ishitatsuyuki commented 6 years ago

I would appreciate that. I'm not sure whether I'm motivated now to implement something huge, but given the recent rise in similar interests (e.g. https://github.com/swc-project/swc), I'll try to look what we can share with them.