Improve compatibility for non-dry-contact configurations.

ratgdo / esphome-ratgdo

ratgdo for ESPHome

GNU General Public License v2.0

357 stars 108 forks source link

Improve compatibility for non-dry-contact configurations. #265

Closed kpfleming closed 4 months ago

kpfleming commented 7 months ago

Don't compile any dry-contact code unless PROTOCOL_DRYCONTACT is defined.
Use BinarySensor instead of GPIOBinarySensor to allow the user to use a template binary sensor (or any other type) if they wish. This is the recommendation of the ESPHome maintainers, and also aligns the C++ code with the Python configuration code (which will accept any type of binary sensor).

Closes #264.

kpfleming commented 6 months ago

@bdraco Would you mind approving the workflows to run in this PR so I can ensure that the changes work in all of the tests in the CI matrix? Thanks.

Awesome-Stuff-Is-Awesome commented 5 months ago

Been about a month ... any updates on this? I believe this would fix an issue I am having with a custom setup without dry-contacts

kpfleming commented 5 months ago

I had been waiting for the CI results to ensure that the changes didn't break anything, and now I see they are all green, so I've marked this 'ready for review'.

bdraco commented 5 months ago

This looks ok to me. If I could not be on an airplane for a few days in a row (or the same time zone) I could test this.

I only have one of the newer boards for testing and its been 1000s of miles away from where I've been at for the last few weeks

bdraco commented 4 months ago

@kpfleming Would you please resolve conflicts

kpfleming commented 4 months ago

Done.