ratgdo / esphome-ratgdo

ratgdo for ESPHome
GNU General Public License v2.0
358 stars 108 forks source link

#214 -- toggle door when open and close dry contacts are triggered together #284

Closed mattjm closed 4 months ago

mattjm commented 5 months ago

This addresses #214. I've been testing it for about a week on a 25i board and it seems reliable.

One thing to note is I made the on-state delay shorter for the buttons--I have a device that is triggering the contacts electronically and it doesn't pull them low long enough for the 500ms delayed_on. I suspect other folks using this feature may be in a similar situation where they have some kind of legacy device they want to use alongside ratgdo.

PaulWieland commented 4 months ago

Thanks for the PR. I already implemented this feature (without realizing this PR was made).

https://github.com/ratgdo/esphome-ratgdo/pull/307/files

The simple else statement should suffice, but if not, please let me know.