search

ratgdo / homekit-ratgdo

A native HomeKit implementation of a Security+ 2.0 garage door controller based on ratgdo hardware
https://ratgdo.github.io/homekit-ratgdo/
GNU General Public License v3.0
214 stars 21 forks source link

Don't reboot ratgdo unless really necessary (save settings) #143

Closed dkerr64 closed 6 months ago

dkerr64 commented 7 months ago

Currently when saving settings the ratgdo device will reboot. For some settings this is unnecessary. I propose changing this so that the device reboots only if required....

Require reboot: WiFi version, Door protocol, reboot every x hours (where X > 0)

Does not require reboot: Require password, Door close delay, reboot every x hours (where X == 0)

Gray area: Device name. Not sure about this one, I don't know if it will propagate through to all services (e.g. mDNS) without a reboot. My preference is to allow for name change without a reboot.

If a setting is changed and reboot is not required, then the webpage would simply refresh to the main page. If reboot required then a 30 second countdown is shown while device reboots and then webpage refreshes to main page.

dkerr64 commented 7 months ago

fix for this queued up in PR #145

jgstroud commented 6 months ago

Fixed in #145