ratgdo / homekit-ratgdo

A native HomeKit implementation of a Security+ 2.0 garage door controller based on ratgdo hardware
https://ratgdo.github.io/homekit-ratgdo/
GNU General Public License v3.0
214 stars 21 forks source link

Security+ 1.0 and Motion Sensor #154

Closed drewcovi closed 3 months ago

drewcovi commented 7 months ago

Not sure if I'm doing something wrong... should motion be reporting in the web ui? I've rebooted a few times, all other sensors seem to be reporting fine. I have the liftmaster 8500 so a bit of a hybrid in the security protocol space (or so I've read).

jgstroud commented 7 months ago

I don't think the motion sensor is currently supported with sec+1. Probably easy to add with the correct opcode

drewcovi commented 7 months ago

Yeah I thought I saw in the matrix that it's supported in mqtt and others, so it seems like it must be possible, just a small update. I'll cross reference and see if it's straight forward.

jgstroud commented 7 months ago

I only have a sec+2 door, so I haven't looked at sec+1 at all yet. I suspect the person that added our sec+1 support doesn't have a motion sensor. It should be easy to add though

PaulWieland commented 7 months ago

Secplus 1 does not support motion sensing. The other firmwares report motion when the light is turned on since the motion sensor triggers the gdo light.

drewcovi commented 7 months ago

So it would just be a matter of doing the same here then... triggering both on recognition of the light. although given they're somewhat interchangeable in regard to automation it's not likely a major showstopper for most.

Honestly not sure how I feel about it. Given the 8500 specifically externalizes the light assembly, and I previously disassembled that light unit to trigger a relay (and by extension turn on all garage ceiling lights), I'm personally treating it just like a motion sensor.

So yeah unless it was a configurable option in the webui to pick one or the other it's a bit redundant.

Either way absolutely love this project and thank you for the hard work here. Love the 2.53i and I do hope it's been rewarding. You've productized this in a way quinled has done and built an army of enthusiasts.

dkerr64 commented 7 months ago

So, we have two choices... remove motion from both the web page and also as a sensor in HomeKit when Sec+ 1 is selected as protocol, or fake it by reporting motion when the light is on.

I'm not sure the second is the same thing. Light can be on for 10's of minutes, that does not mean that motion is taking place that whole time.

Personally I would choose to remove motion sensor accessory from HomeKit and the web page.

drewcovi commented 7 months ago

Well it's not unusual for motion sensors of all stripes to have a configurable timeout to conserve battery. It might be useful as an either or toggle.

At that point it's just more flexible and potentially a better reflection of individual setups (jackshaft openers don't even require you plug in the light).

I've often thought of it as an "activity" switch since it also activates when the door opens. But I'm probably getting too deep down the rabbit hole 🤣.

Either way I agree it should be one or the other. Both seems a little silly.

PaulWieland commented 7 months ago

The way the motion sensors work is they send a motion detected message and that’s it. There’s no time out, no clear, etc. it’s just an event that says hey, motion was detected.

So it’s useful for triggering automations, but not useful for showing a status.

drewcovi commented 7 months ago

Yeah, nothing compares to mmWave style occupancy sensors, but those things would need to be wired, and those are not what we're getting on the opener buttons.

But I agree it's not a typical motion sensor, and to replicate the expected functionality would mean simply mapping the light-off signal to clear which should be every 4.5 min unless they've modified it by pressing and holding the lock button.

dkerr64 commented 7 months ago

I think @PaulWieland is saying that it just does a notification, so there is never anything to clear. So I now understand why using light turning on is a reasonable approach.

bkolaci commented 5 months ago

I just got ratgdo installed and works great. I noticed that the motion sensor no longer turns on the light nor shows up on the panel. But I read that looking at the light is an approach, however my light never turns on (since installation). Is it still supposed to? I thought @PaulWieland said it wasn't supported.

So I just took the ratgdo board out and hooked the switch back directly to the opener. The motion detector in the switch turns the light on again. Verified after it went off to trigger it again and it does work. Then I put ratgdo back into the circuit and it doesn't trigger the light anymore.

dkerr64 commented 3 months ago

@bkolaci please test with v1.7.0 (tagged as pre-release so select that checkbox on the firmware update dialog)

bkolaci commented 3 months ago

Sorry, I actually replaced the whole brand new opener with latest security now and updated ratgdo to the latest. It works great with the new opener, no issues. The motion sensor works properly too.

dkerr64 commented 3 months ago

Will assume we're working in v1.7