search

ratgdo / homekit-ratgdo

A native HomeKit implementation of a Security+ 2.0 garage door controller based on ratgdo hardware
https://ratgdo.github.io/homekit-ratgdo/
GNU General Public License v3.0
214 stars 21 forks source link

1.4.2 Closed status delayed by minutes #187

Closed gfreestone closed 5 months ago

gfreestone commented 5 months ago

Whenever door closes, HomeKit doesn't get the notification/update for several minutes.
image

jgstroud commented 5 months ago

The title says 1.4.2. Is this a regression? Is this consistent? I'm not sure what can cause this. The characteristic gets updated immediately.

jgstroud commented 5 months ago

Interesting. I just reproduced the issue. The open updated immediately, but not the closed. Hopefully an easy fix.

gfreestone commented 5 months ago

I worked backwards, downgrading the firmware. The issue was in all 1.4 versions.

jgstroud commented 5 months ago

Yeah, it was introduced a while ago. HomeKit just seems to be missing the update. I see it in the log. I reverted a commit and pushed it. Fixed in the 1.4.3 build.

gfreestone commented 5 months ago

Just tested 1.4.3 and it seems much better! Thanks!

jgstroud commented 5 months ago

I don't know why HK seems to miss the closed state change. It's the same code that sets the open state change and that doesn't seem to be missed. And this was working at some point. But I had noticed recently that the closed state was taking a while to update from my car. I had just assumed it was delays due to remote (not wifi) updating.