search

ratgdo / homekit-ratgdo

A native HomeKit implementation of a Security+ 2.0 garage door controller based on ratgdo hardware
https://ratgdo.github.io/homekit-ratgdo/
GNU General Public License v3.0
215 stars 21 forks source link

Allow setting different username #225

Closed donavanbecker closed 2 months ago

donavanbecker commented 3 months ago

would be nice if the username could be changed from admin to something else.

dkerr64 commented 3 months ago

Request noted. Yes username could be changed, just a small matter of programming it. Will consider for a future release.

donavanbecker commented 3 months ago

With that would multi user support be useful?

dkerr64 commented 3 months ago

With that would multi user support be useful?

I think that is a stretch. Much more complex to implement, and what's the point? I don't want to encourage use of the web interface... it should be for admin purposes only. Apple Home or other HomeKit apps is how most should interact with the door, not the web page.

I can think of a (quite niche case) where changing from "admin" to something else may be useful, but I'm not seeing it for multiuser.

David

donavanbecker commented 3 months ago

Totally understand, I don't need it but figured I would propose it.

dkerr64 commented 3 months ago

Will implement in next release whenever we do that... is in PR #227

donavanbecker commented 3 months ago

Working awesome @dkerr64!!

Anyway to change the login pop up so that it supports autofill on mobile?

image

dkerr64 commented 3 months ago

We're using basic browser-based digest authentication. The popup is generated by the browser so, AFAIK, I cannot influence how that popup appears or whether the mobile (or desktop) browser will offer to autofill the fields.

The alternative would be to implement our own login dialog... that requires we implement our own and not rely on browser-based digest authentication. This, in-fact, is best practice which is why you rarely see browser popups for userid/password anymore on web sites (it's considered insecure). But a lot of work I think and I'm not sure it is worth the effort especially given we cannot implement SSL (https).

dkerr64 commented 2 months ago

included in v1.7.1