search

ratgdo / homekit-ratgdo

A native HomeKit implementation of a Security+ 2.0 garage door controller based on ratgdo hardware
https://ratgdo.github.io/homekit-ratgdo/
GNU General Public License v3.0
214 stars 21 forks source link

Move dangerous buttons to password protected area #235

Closed JKaniarz closed 1 month ago

JKaniarz commented 1 month ago

I'd like to see the Firmware Update, Un-pair HomeKit, and Reboot buttons moved to the password protected page. Those are "admin" level features that could be used to covertly break into the house. (the other buttons are fine because they generate notifications)

dkerr64 commented 1 month ago

Firmware updates and re-pairing are already password protected... if you are not seeing the prompt then it is because browsers cache credentials and only request userid/password if credentials expire or change. Those and reboot are also wrapped with a "are you sure" popup.

Reboot is not password protected. This was a conscious decision as reboot is non-destructive, it takes ~30 seconds to reboot and re-connect to the Apple Home network.

JKaniarz commented 1 month ago

I'm glad to hear it's secure, but it's not obvious that it is. I knew to test in incognito mode, but I wasn't expecting the password prompt to be after the point of no return. I assumed that "are you sure" meant there were no further guardrails.

Will you consider showing the password prompt right after the first click for the firmware and unpair buttons to make it more obvious?

dkerr64 commented 1 month ago

Yes, let me check that, we can change to do the credentials check before the are you sure pop up.

Thanks for the suggestion.

dkerr64 commented 1 month ago

I have made this change in PR #227 so will be included in next release.

dkerr64 commented 1 month ago

fixed in v1.7.1