ratgdo / homekit-ratgdo

A native HomeKit implementation of a Security+ 2.0 garage door controller based on ratgdo hardware
https://ratgdo.github.io/homekit-ratgdo/
GNU General Public License v3.0
214 stars 21 forks source link

allow customization of syslog port #245

Open SShah7433 opened 3 weeks ago

SShah7433 commented 3 weeks ago

Allow for syslog to be sent to ports other than 514. Many syslog listeners use ports to segment data or listen on non-privileged ports.

jgstroud commented 3 weeks ago

How important is that feature to you? The feature is trivial to implement, but IMHO, seems excessive for this device and use case. For segmenting data, syslog has different logging facilities, which we use LOCAL0, and it also filters based on hostname. out of the box rsyslog creates separate logs for every remote host.

Every setting we add has the downside of chewing up bytes of RAM, so I want to understand how important it is. Also, if we do implement, it must remain UDP. While technically possible, we definitely will not implement TCP because it has major memory usage implications.

SShah7433 commented 2 weeks ago

It's nice to have, but it's a low priority. I can work around it fairly easily, so in the spirit of preserving memory for more requested features, let's backlog this.

jgstroud commented 2 weeks ago

Thanks for the update. It's a mostly trivial feature, so we may still add this but we have a few higher priority tasks at the moment.

phybersplice commented 1 week ago

It's nice to have, but it's a low priority. I can work around it fairly easily, so in the spirit of preserving memory for more requested features, let's backlog this.

I came here to say I was setting up OpenObserve and it runs on TCP & UDP of 5514 (custom port). I'd love to see syslogging to a custom port - whenever it can be implemented. Appreciate all the hard work!

dkerr64 commented 6 days ago

Request noted. I'm kind of busy right now but will note it as a to-do for the next update.

dkerr64 commented 6 days ago

Added in PR #247 so will be in next release whenever we do that.

phybersplice commented 6 days ago

Absolutely no rush. Thank you. Very much appreciated whenever it can be implemented.