rath3t / dune-iga

A DUNE grid implementation with NURBS as ansatz functions.
https://rath3t.github.io/dune-iga-doc/
Other
1 stars 1 forks source link

Parameters for IntegrationRuleCreator shouldn't be hardcoded #31

Open henrij22 opened 11 months ago

henrij22 commented 11 months ago

As of now the parameter used for creating the subgrids which determine the precisness of geometry approximation are hardcoded in subgrid.hh as follows:

/// Parameters
static constexpr int maxOuterBoundaryDivisions{10};
static constexpr int maxInnerBoundaryDivisions{10};

static constexpr double outerTargetTolerance{1e-4};
static constexpr double innerTargetTolerance{1e-4};

This could be done for example with set default values and the possibility of an input file which overrides these default values. Maybe add a settings struct that can be passed into the trimmer / subgrid.

It would also be good if at least some of these settings could be changed during run-time and not compile-time.

henrij22 commented 11 months ago

See also #16 -> define interface