This is meant to keep track of unfinished buisiness. These points don't have to be adressed before merging #46
[ ] #47
[ ] How to handle preferences and parameters for trimming (Integration rule parameters are currently transferred via a singelton object)
[ ] check implementation of TrimmedReferenceElement
[ ] think about IndexSet, currently index for elements is unique, but should be independent index Set for trimmed and full, this will break the basis implementation atm
[ ] Ensure that boundarySegmentIndex is consecutive for trimmed patches
[ ] Enable checkBoundarySegment test, either its not correctly implemented or the test fails because its not suited for none-reference elements
[ ] Check implementation of
auto secondFundamentalForm(const LocalCoordinate& local) const {
return patchGeometry_->secondFundamentalForm(local);
}
auto zeroFirstAndSecondDerivativeOfPosition(const LocalCoordinate& local) const {
return patchGeometry_->zeroFirstAndSecondDerivativeOfPosition(local);
}
This is meant to keep track of unfinished buisiness. These points don't have to be adressed before merging #46
TrimmedReferenceElement
IndexSet
, currentlyindex
for elements is unique, but should be independent index Set for trimmed and full, this will break the basis implementation atmboundarySegmentIndex
is consecutive for trimmed patchesIdType
false
) ⚠️ this function doens't seem to be ever tested or compiled in our testing suiteBacklog
FIxed
volume
function for trimmed elements ingeometrylocalView
globalRefine
crashes when called with a value greater 1volume()
methods for trimmed geometriesGeometry<griddim>
to be constructable from aFieldVector
center()
method is currently invoked viaDefaultGeometryImplementation
whereglobal(0.5)
is called which doesn't make sense for trimmed geometries