Rolling ToDo List for PR #46

This is meant to keep track of unfinished buisiness. These points don't have to be adressed before merging #46

[ ] #47
[ ] How to handle preferences and parameters for trimming (Integration rule parameters are currently transferred via a singelton object)
[ ] check implementation of TrimmedReferenceElement
[ ] think about IndexSet, currently index for elements is unique, but should be independent index Set for trimmed and full, this will break the basis implementation atm
[ ] Ensure that boundarySegmentIndex is consecutive for trimmed patches
[ ] Enable checkBoundarySegment test, either its not correctly implemented or the test fails because its not suited for none-reference elements
[ ] Check implementation of

auto secondFundamentalForm(const LocalCoordinate& local) const {
      return patchGeometry_->secondFundamentalForm(local);
    }

    auto zeroFirstAndSecondDerivativeOfPosition(const LocalCoordinate& local) const {
      return patchGeometry_->zeroFirstAndSecondDerivativeOfPosition(local);
    }

[ ] Reimplement correct hash function for IdType

template <typename HostIdType>
struct std::hash<Dune::IGANEW::DefaultTrim::IdType<HostIdType>>
{
std::size_t operator()(const Dune::IGANEW::DefaultTrim::IdType<HostIdType>& k) const

[ ] The line https://github.com/rath3t/dune-iga/blob/6cb633bee203431a9e4f903d021da3abf2bb282a/dune/iga/nurbsbasis.hh#L666 was changed to https://github.com/rath3t/dune-iga/blob/3c55b2fc3db85d422f66f35baf62c8734cb912e9/dune/iga/nurbsbasis.hh#L700-L702 (getting rid of the false) ⚠️ this function doens't seem to be ever tested or compiled in our testing suite

Backlog

[ ] #3

FIxed

[x] #31
[x] test volume function for trimmed elements in geometrylocalView
[x] globalRefine crashes when called with a value greater 1
[x] implement volume() methods for trimmed geometries
[x] Refactor trimmed Geometry<griddim> to be constructable from a FieldVector
[x] center() method is currently invoked via DefaultGeometryImplementation where global(0.5) is called which doesn't make sense for trimmed geometries
[x] test center method

rath3t / dune-iga

Rolling ToDo List for PR #46 #50

Backlog

FIxed