Outdated card0 checks - Githubissues

rathena / FluxCP

A web-based Control Panel for rAthena servers written in PHP. Manage player accounts, databases, support tickets, etc via your browser.

GNU Lesser General Public License v3.0

175 stars 207 forks source link

Outdated card0 checks #190

Open cydh opened 6 years ago

cydh commented 6 years ago

Checking using card0 == 254, card0 == 255, card0 == -256 is outdated. rAthena changed the value years ago, and those values must be moved to config and make function/method if want to be checked.

What I think is in PR #194

aries-delossantos commented 6 years ago

@cydh hi im not sure what the card0 checks are for but I've used the same checking for vending update https://github.com/rathena/FluxCP/pull/193

cydh commented 6 years ago

card0 is identifier to check if the item is forged, creation (from brewing/cooking, getnameditem) or pet egg (flag for renamed)

#define CARD0_FORGE 0x00FF
#define CARD0_CREATE 0x00FE
#define CARD0_PET 0x0100

ur usages and current usages are for older rA (and other emu) before we implement UINT16_MAX for item ID