search

rathena / rathena

rAthena is an open-source cross-platform MMORPG server.
https://rathena.org/board/
GNU General Public License v3.0
2.9k stars 2.33k forks source link

Ranger[Camouflage] vs Targeted Skills #332

Closed reigneil closed 9 years ago

reigneil commented 9 years ago

is this intended that you are not immune to monster targeted skill? i'm mean monster will not see you but can use targeted skill like Fire Bolt if you are in its range of attack. based on this video kRO server you cannot be targeted if you are in Camouflage unless you are targeted before Camouflage take effect: https://www.youtube.com/watch?v=QLzXzDhb2xA credit to Ziu

aleos89 commented 9 years ago

So you're saying that when Camouflage is active, you are being targeted by skills still?

reigneil commented 9 years ago

yes it is. how to reproduce: just use camouflage skill then summon monster id 1716 which is Acidus with Lightning Bolt skill for about 10 of it then see these monsters targeting you with Lightning Bolt. what i know is only player can target you while using it but not monster that do not bypass it like boss protocol monster.

reigneil commented 9 years ago

to fixed this there must be separate code for BL_MOB and BL_PC skill_id here in status.c: if (tsc->data[SC_CAMOUFLAGE] && !(is_boss || is_detect) && !skill_id) return false; EDIT: rewrite the coding credit to hercules much like official behavior to me... if( tsc->data[SC_CAMOUFLAGE] && !(is_boss || is_detect) && (!skill_id || (flag == 0 && src && src->type != BL_PC))) return false;

reigneil commented 9 years ago

further investigation shows that this behavior is not intended in the first place. /facepalm http://forums.irowiki.org/showthread.php?t=95899 quote "Camouflage - Fixed a bug where a ranger in camouflage state could be targeted by single target skills." so... you may now remove !skill_id check now. if (tsc->data[SC_CAMOUFLAGE] && !(is_boss || is_detect)) return false; or better to merge this code with other skill with the same behavior. BTW this fixed is not yet implemented in iRO... but implemented in kRO main server http://forums.warpportal.com/index.php?/topic/130315-unofficial-ragnarok-what-to-look-forward-to-thread/

aleos89 commented 9 years ago

Thanks for the confirmation. Was looking for that!

RagnarokNova commented 9 years ago

From what I can read on the skill, it's basically supposed to work like cloaking, but right now the skill is also making you immune to AoE damage.

reigneil commented 9 years ago

yeah @aleos89 forgot to change the property of it like cloaking. i realize that i provide wrong fixed... better wait for @aleos89 to fixed this..