Mob Asura Strike (Chen Bio4) and Ghostring Card effect

[slyx88]

• rAthena Hash:

• Client Date: 2017-06-14

• Server Mode: Renewal

• Description of Issue: Asura strike is not reduced by ghostring card

  • Result: Asura damage, in the range between 14k -19k in both conditons (with GR card and without GR card)
  • Expected Result:The damage from this skill should be reduced due to level 1 ghost elemental bonus from GR card
  • How to Reproduce: Summon chen and compare the asura damage before and after wearing armor carded with GR card
  • Official Information: A Nova RO player tested it in kRO sakray. https://www.novaragnarok.com/forum/bug-tracker/fixed-bugs/asura-from-chen-x-r448/

• Modifications that may affect results:

[MathReaper]

I assume that you just need to call battle_attr_fix for the wd.damage on the battle_calc_skill_base_damage just as it's called for the players.

Like this: wd.damage = battle_calc_base_damage(src, sstatus, &sstatus->rhw, sc, tstatus->size, i); wd.damage = battle_attr_fix(src, target, wd.damage, ELE_NEUTRAL, tstatus->def_ele, tstatus->ele_lv);

wd.damage2 = battle_calc_base_damage(src, sstatus, &sstatus->lhw, sc, tstatus->size, i); wd.damage2 = battle_attr_fix(src, target, wd.damage2, ELE_NEUTRAL, tstatus->def_ele, tstatus->ele_lv);

I did 20 tests for each of these: Without ghostring card: min: 524k max: 713k avarage: 636k

With ghostring card: min: 386k max: 506k avarage: 454k

Approximately 30% of damage reduced after equipping Ghostring Card.

[slyx88]

Thank you for your respond and solution @MathReaper . But from the battle_attr_fix, wouldn't that make all other mob skills become forced neutral? Correct me if im wrong.I am still in beginner level in programming =D

[MathReaper]

Yeah, probably, you can do alot of things to correct this, like, make a if-statement only for the skill that you want. But, currently, the rAthena is not making any usage of battle_attr_fix for monsters I guess, so maybe every skill is being neutral applied? I don't know.