DEF reduction from tanking multiple enemies

[mrjnumber1]

• rAthena Hash: latest

• Client Date: x

• Server Mode: either

• Description of Issue:

  • Result: 1) DEF reduction is incorrectly calced from gears when mobbed 2) DEF reduction is calculated prior to player DEFF2 calculation, which algebraiacally introduces some discrepancies. 2) Crusader+ def reduction is incorrectly calced during CR_GRANDCROSS. 3)
  • Expected Result: DEF reduction from tanking multiple enemies to be correct, of course!
  • How to Reproduce: tank monsters, compare damage across athena/aegis
  • Official Information: Please see these links DEF1 calc (pre-RE and RE are analagous aside from some efst calculations) DEF2 calc (the idea is similar in RE but the base vit_def calculation is stored elsewhere and a weird formula. that's OK). I assume both actually do do 5 * def * (enemycount-2) / 100 because one is optimized in a wacky way.

In summary, the penalty for players tanking mobs is incorrectly calced. We have it (default configged to) -5 base DEF/base DEF2 for each enemy attacking you, and then calcing vit DEF from there. The main takeaways I can think of are this.

• DEF penalty for each attacker is not -5 DEF/DEF2 per mob over 3, it should instead be deftype -= 5 * deftype* (target_count - (battle_config.vit_penalty_count-1)) / 100 for DEF and DEF2 but with the following accounted for...

• Statuses are applied to DEF/DEF2 before attacker count reductions

• DEF/DEF2 is only reduced by gear if they are below 3 attackers. You can see me testing this (on a Pre-RE zone) here https://streamable.com/ytksc4

• If the user is a sader+ casting GC, the GC DEF casting penalty is only calced with below 3 attackers. Videos of testing with few enemies, damage is static and then a sudden burst for 1s https://streamable.com/qmbuk4. With many enemies, no damage change https://streamable.com/obfkjs

• Modifications that may affect results: x

[Playtester]

@mrjnumber1 Why is the refinement bonus 0.8 in that file? Was it modified?

[mrjnumber1]

@mrjnumber1 Why is the refinement bonus 0.8 in that file? Was it modified?

Hi sorry for the late reply, I double checked and it must have been a typo. I have 0.699999988079071, likely the closest float approximation to 0.7. i must have accidentally written 0.8 when transcribing it.