search

rathena / rathena

rAthena is an open-source cross-platform MMORPG server.
https://rathena.org/board/
GNU General Public License v3.0
2.81k stars 2.26k forks source link

WL_TETRAVORTEX_FIRE sends WL_TETRAVORTEX_WIND packet?? #6519

Open MrAntares opened 2 years ago

MrAntares commented 2 years ago

skill.cpp line 3771-3773:

        case WL_TETRAVORTEX_FIRE:
            dmg.dmotion = clif_skill_damage(dsrc, bl, tick, dmg.amotion, dmg.dmotion, damage, dmg.div_, WL_TETRAVORTEX_WIND, -1, DMG_SPLASH);
            break;

This line causes the server to send the packet 0x1de (PACKET_ZC_NOTIFY_SKILL2) with WL_TETRAVORTEX_WIND. This causes no property issue in the damage (because it is only an info for the client), but the client thinks it is using the WL_TETRAVORTEX_WIND element skill, so if the skill name would display, it would show Tetra Vortex Wind!! (WL_TETRAVORTEX_WIND) instead of Tetra Vortex Fire!! (WL_TETRAVORTEX_FIRE). This is a problem in custom clients, and if the official client decides to start displaying autoskill names it will be an official issue as well.

What is even the purpose of this line??

aleos89 commented 2 years ago

This skill always had messed up behavior and Gravity changed it several times client side over the years. I can't really remember now the specifics but might be best to get a new capture from kRO and see how it's working now, if it has changed again.