Swapping equipment/cards with combo leads to incorrect HP/SP

[kutsuru]

• rAthena Hash: b13bc7402

• Client Date: 2018-04-18b

• Server Mode: Pre-Renewal

• Description of Issue:

  • Result: HP/SP are not properly set when swapping equipment/cards involving combo
    

  • Expected Result: HP/SP should remain the same value as MaxHP/MaxSP

  • How to Reproduce: Issue can be reproduced with the Fricco's Shoes[0]-2417, Odin's Blessing[1]-2353 and Falcon Muffler[0]-2516 for equipment and the Dark Illusion-4169+ Dark Lord-4168 combo for cards. By simply swapping the same equipment, MaxHP and MaxSP will remain the same, but HP and SP will not and be set to the value without the combo.

  • Official Information: N/A

• Modifications that may affect results:

  • This is mainly due to the fact that during unequip, if a combo is removed it will force update the status even in the context of swapping equipment.
  • https://github.com/rathena/rathena/blob/master/src/map/pc.cpp#L11597 for equipment
  • https://github.com/rathena/rathena/blob/master/src/map/pc.cpp#L11611 for cards
  • Most probably above statements should take into consideration the passed flag (&& flag & 1)

[aleos89]

Are you able to reproduce this after #6162? Your hash is several years old now.

[Atemo]

I can't reproduce on https://github.com/rathena/rathena/commit/c092c8711beef4630c8c9894a3763c7176960b03

[kutsuru]

I could reproduce on 701c6f6239faff10a8719a3b0578b6ec0e805bbb, will check this weekend on latest commit

[kutsuru]

I can't reproduce on c092c87

What did you test ? I've just tested on up to date repo, still reproducible.

[Atemo]

Fricco's Shoes + Odin's Blessing + Falcon Muffler with and without Dark Illusion + Dark Lord and you?

[kutsuru]

Exactly same as in the initial picture, I replace the Fricco's with another Fricco's and HP drops, and it should not.

[Daraen1]

I can reproduce too, i use 2018-04-18b client date and my source is up to date. I use Pre-renewal.

[aleos89]

The reason your HP/SP drops is because you're effectively unequipping the first item -> status update applied to HP/SP lowering the max and current since bonus is gone -> equipping second item -> status update applied to HP/SP increasing max but current stays at current value.

Can you prove on kRO that a players HP/SP doesn't change when switching with the same item? What happens if the same item has cards or enchants that adjusts HP/SP?

[kutsuru]

Sorry @aleos89 I have no way to prove the behaviour on kRO, but you would expect the same behaviour as when no combos are involved Naked => 4311 HP Diablos Boots => 5301 HP Swapping to Sleipnir[0] => 5173 HP

Swapping to Sleipnir[0] did not reset HP to base HP

[kutsuru]

Hello @aleos89, would not it make more sense to have the same behaviour for both scenario ?

[Playtester]

Tested on official servers: If you change your equip, it will first unequip an item, this will reduce your HP/SP, then on equipping the new item, your current HP/SP remain the same.

So yes, you get effectively damaged by changing equip, even if you change to the same type of equip.

Same behavior for combos. First the combo is unequipeed - you lose HP/SP, then combo bonus is reactivated, keep current HP/SP, only max MaxHP/SP returns to previous value.

So yeah, it should have the same behavior for both scenarios, but it should be the other way around.

[kutsuru]

Thanks for the investigation/fix, well that was not the expected result but the purpose is to match official behaviour, I guess :)