search

rathena / rathena

rAthena is an open-source cross-platform MMORPG server.
https://rathena.org/board/
GNU General Public License v3.0
2.86k stars 2.29k forks source link

Retrieving Guild Bounded Items from the expelled member #8033

Open gidzdlcrz opened 9 months ago

gidzdlcrz commented 9 months ago

Is your request related to a missing official feature?

Yes

Describe the solution you'd like

Related to this commit -> https://github.com/rathena/rathena/commit/eec798bfc3be36b8896d11a39a4edcfccd31ff00. It works! But upon my testing. If the position is not allow to open guild storage you wont get the guild bounded items and upon expelling the member the item will be fully lost.

Describe alternatives you've considered

No response

Additional context

The storage permit should be bypassed.

aleos89 commented 9 months ago

I remember this being an old mention, but I looked through the source and also just ran a few tests. I was able to confirm that the guild bound items were returned to the guild storage if the player is offline or online and they do not have the guild storage permission applied to their guild role.

If you're having issues, please try testing on a clean rAthena and confirm it works for you.

gidzdlcrz commented 9 months ago

I remember this being an old mention, but I looked through the source and also just ran a few tests. I was able to confirm that the guild bound items were returned to the guild storage if the player is offline or online and they do not have the guild storage permission applied to their guild role.

If you're having issues, please try testing on a clean rAthena and confirm it works for you.

Oh yeah sorry. But i did check it using latest pull from git w/ pre re setup. I know that there is an option to make the storage work in pre re using that. But alas. It worsen the problem. The guild bounded items are not getting removed with or w/o the guild storage permission. Maybe because im on pre re.

aleos89 commented 9 months ago

I didn't notice any pre-re defines. The only difference is having to add the Guild Storage skill into pre-re databases. I just tested and it still works as it should -> item gets sent back to storage after expel while the player does not have storage permissions.

Litro commented 9 months ago

this case happen its because the guild storage never intialized yet then kicking member with guild bound item, because guild storage initialized on first open request of guild storage

https://github.com/HerculesWS/Hercules/issues/691