Switch `name` field in CRDs to `type`

akashsinghal commented 7 months ago

What would you like to be added?

Ratify has introduced new type field for CLI scenarios of verifier allowing for multiple instances of same verifier with unique config to exist at once. Right now, the type field used in CLI maps to the name field in CRD and the uniquely identifier name in CLI is equivalent to CRDs metadata.name. Moving forward, we should switch name field to type in CRDs.

This will require:

introducing Type field to all CRD spec of store, verifier, and policy
support both Name and Type field until v2.0
update all docs spec to use type and add deprecation warning in spec to name field.

Anything else you would like to add?

No response

Are you willing to submit PRs to contribute to this feature?

[ ] Yes, I am willing to implement it.

susanshi commented 1 month ago

Hi @junczhu , we discussed in community meeting. Please help us understand if both property is available now, the plan is to deprecate "name" in ratify v2.0.0

junczhu commented 2 weeks ago

Hi @junczhu , we discussed in community meeting. Please help us understand if both property is available now, the plan is to deprecate "name" in ratify v2.0.0

Property is currently not available in CRDs, we may need to introducing the Type field as mentioned above

susanshi commented 2 weeks ago

not critical for 1.3 , may spill over to 1.4

junczhu commented 1 week ago

ratify-project / ratify