ratify-project / ratify

Artifact Ratification Framework
https://ratify.dev
Apache License 2.0
225 stars 63 forks source link

feat: update crds and default templates #1941

Open junczhu opened 2 days ago

junczhu commented 2 days ago

Description

What this PR does / why we need it:

image image

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes # 1888

Objective Ensure the overall user experience of the CRL feature is consistent.

  1. Ratify Preload Workflow (kmp) 1.1 Verify the AKV provided certificate chain (in the same team pub-sub scenario to ensure the full cert chain is included); inline holds only the root cert as a verifier; notation retrieves the chain from the signature.
    • [*] AKV, implemented in 1.4.0
    • Inline, not included in this feature
    • (Going to create New Issue to track) Manual/raw byte/distributed point URL input [Azure integration]

1.2 Feature flag about caching: Ratify close cache, notation revocation check cache, align notation trust policy with the notation config.

  1. Handle Non-Manual Loading

    • Ensure non-manual loading processes, loading happening in the verifier, are aligned with CRL preloaded on purpose. This includes using the same configuration for fetcher and cache (refresher is optional as listed below).
  2. Configuration Enhancements

    • [Nice to have] Expose fetcher timeout config, retry config, and set a default value for these configurations.

Questions

-----------------WHICH IS NOT PLANNED FOR 1.4.0------------------------

  1. Refresh Configuration
    • Notation currently refreshes when CRLs are used and found to be expired. Should ratify set a period for regular checks?
    • [Optional] Also refresh notation download checks. If this is not implemented, the notation verifier would redo the check and download the new CRL. Since this is not on a critical path, mark it as optional.

Open Questions

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Checklist:

Post Merge Requirements

junczhu commented 12 hours ago

cc\ @yizha1 @FeynmanZhou for a heads-up