Open akashsinghal opened 4 days ago
All modified and coverable lines are covered by tests :white_check_mark:
interesting that cosign signs with the command vs notation we use the action. Curious if both are available, is it better to use the command or the action?
yeah good point. It seems that cosign github action is only for installation. recommended way is to use cosign
cli directly once installed on runner.
Description
What this PR does / why we need it:
This PR adds release image signing using Notation and Cosign for all release images:
ghcr.io/ratify-project/ratify
,ghcr.io/ratify-project/ratify-crds
,ghcr.io/ratify-project/ratify-base
. The next minor version releasev1.4.0
will utilize the new signing workflow.Doc update PR: https://github.com/ratify-project/ratify-web/pull/129/files
Sample workflow showing release flow successful: https://github.com/akashsinghal/ratify/actions/runs/11963756788/job/33354797232
Cosign signature attached:
Notary Project signature attached:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1437
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change