rationalmatter / Juno-Issue-Tracker

Defect Tracker for Juno
76 stars 1 forks source link

Juno Connect keymap conflicts with widget created with mols2grid library #398

Open macardosa opened 2 months ago

macardosa commented 2 months ago

Describe the bug When using the display function provided by module mols2grid, a grid-type widget is shown in the output cell with molecules structures. A search bar is provided where we can do pattern matching with SMARTS to filter out some of the structures. However typing letters such as O, I, and many others is not possible within Juno Connect, as those letters have “another purpose”. Within Juno Connect it is not possible to use as intended the library mols2grid.

To Reproduce

!pip install rdkit-pypi mols2grid
import mols2grid
import pandas as pd
df = pd.read_csv("https://raw.githubusercontent.com/PatWalters/practical_cheminformatics_tutorials/main/data/smarts_test.smi",sep=" ",names=["SMILES","Name"])
mols2grid.display(df,subset=["img","Name"])

Expected behavior The user can type any letter or character on the search bar.

Screenshots

image

Environment (please complete the following information):

alexstaravoitau commented 1 month ago

Thanks for reporting @macardosa—yep definitely a bug, I will have to look into this... I think it should still work with the on-screen keyboard though, as it shouldn't trigger any keyboard shortcuts. I'll see how I can work around it for hardware keyboards as well.

macardosa commented 1 month ago

Hello,

Thanks for answering. I didn't try with the keyboard on screen, because I use a hardware keyboard with the iPad. Your app looks very nice, but minors details lile this discourage me to use it. I bought this app on the App Store, can I get a refund? @alexstaravoitau I am currently not using your app.

Best regards

alexstaravoitau commented 1 month ago

@macardosa Thanks and no worries—you may need to contact App Store support directly for a refund, because Apple doesn't let developers process refunds, unfortunately. They have a straightforward process for this though.

macardosa commented 1 month ago

Thanks. In that case I think I might not qualify for a refund since I bought the app some time ago. But I appreciate your willingness to help. Do you have a desktop version for your app?

On May 12, 2024, at 4:17 PM, Alex Staravoitau @.***> wrote:

@macardosa https://github.com/macardosa Thanks and no worries—you may need to contact App Store support directly for a refund, because Apple doesn't let developers process refunds, unfortunately. They have a straightforward process for this though.

— Reply to this email directly, view it on GitHub https://github.com/rationalmatter/Juno-Issue-Tracker/issues/398#issuecomment-2106262272, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARN34CAZ6BP2NJWYG3AVAH3ZB52WXAVCNFSM6AAAAABHA3TWEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGI3DEMRXGI. You are receiving this because you were mentioned.

alexstaravoitau commented 1 month ago

The iPad version is available for Apple Silicon macs, although I haven't extensively tested it I'm afraid.