search

ratmice / nimbleparse_lsp

lsp server for grmtools lex & yacc
Other
7 stars 1 forks source link

Remove unnecessary `&mut self` to updated_lex_or_yacc_file. #28

Closed ratmice closed 1 year ago

ratmice commented 1 year ago

This should in theory allow for some further cleanup, as I believe it was stopping us from refactoring some stuff out into functions.

Probably wait to merge until these changes are finished

ratmice commented 1 year ago

So, I think this is better at least and probably ready, but will sit on it for a few days in case I can come up with any other ideas on ways to clean this up.

ratmice commented 1 year ago

So most of the things i've come up with for further improvement are better done in their own branch, and this is a better starting point for that. As such i'm going to merge...

The next thing to experiment with here is having ParserData, and the RTParserBuilder in a self referencing struct which will likely require some unsafe code. Part of the difficulty there is that RTParserBuilder has a generic lifetime, so it isn't really clear that this would in fact be better, but it would allow the thing owning the parser builder to have a self type, and impl traits.