Open TimothyLoyer opened 10 months ago
Same issue here. I'd be happy to provide a sample file for the extracted pgs subs.
Having the same issue, too, on Ubuntu 22.04/Python 3.10:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/pgsrip/core.py", line 69, in rip_pgs
srt = PgsToSrtRipper(p, options).rip(lambda t: rules.apply(t, '')[0])
File "/usr/local/lib/python3.10/dist-packages/pgsrip/ripper.py", line 128, in __init__
max_height = max([item.height for item in self.pgs.items]) // 2
File "/usr/local/lib/python3.10/dist-packages/pgsrip/media.py", line 161, in items
self._items = self.decode(data, self.media_path)
File "/usr/local/lib/python3.10/dist-packages/pgsrip/media.py", line 182, in decode
self.dump_display_sets(display_sets)
File "/usr/local/lib/python3.10/dist-packages/pgsrip/media.py", line 189, in dump_display_sets
f.write(f'{new_line.join([str(ds) for ds in display_sets])}')
File "/usr/local/lib/python3.10/dist-packages/pgsrip/media.py", line 189, in <listcomp>
f.write(f'{new_line.join([str(ds) for ds in display_sets])}')
File "/usr/local/lib/python3.10/dist-packages/pgsrip/pgs.py", line 449, in __str__
strings.append(f'\t{s}')
File "/usr/local/lib/python3.10/dist-packages/pgsrip/pgs.py", line 206, in __str__
for k, v in self.to_json().items():
File "/usr/local/lib/python3.10/dist-packages/pgsrip/pgs.py", line 191, in to_json
return {
File "/usr/local/lib/python3.10/dist-packages/pgsrip/pgs.py", line 192, in <dictcomp>
k: to_value(getattr(self, v)) for k, v in attributes.items() if getattr(self, v) is not None
File "/usr/local/lib/python3.10/dist-packages/pgsrip/pgs.py", line 274, in window_id
return self.data[1]
IndexError: index out of range
A sample file is needed to debug this
I getting this error for episodes I've ripped from a few particular series. In most cases I've had no problem, but these appear to be getting something unexpected - maybe there is an edge case which needs handled? I'll see whether I can use MKVToolNix to rip the subtitle tracks.
Thank you for a great tool!