search

ratschlab / HIRID-ICU-Benchmark

Repository for the HiRID ICU Benchmark (HiB) project
MIT License
49 stars 10 forks source link

Fixing paths #22

Closed epierson9 closed 1 year ago

epierson9 commented 1 year ago

Attempts to resolve https://github.com/ratschlab/HIRID-ICU-Benchmark/issues/17.

hugoych commented 1 year ago

Hi Emma, Your PR looks good! The test failed because of a new default version of xarray which causes conflict. I fixed it in the main branch (see https://github.com/ratschlab/HIRID-ICU-Benchmark/commit/84b48fc448340a71e8c2f13c7f062c8d7ea21d0d). Could you do the same with your fork? It should pass test Thanks a lot !

epierson9 commented 1 year ago

I believe I've now fixed this - is that what you meant? If so, feel free to merge in!

hugoych commented 1 year ago

Thanks a lot Emma !

epierson9 commented 1 year ago

of course, thanks for being so responsive!

On Thu, Sep 1, 2022 at 9:53 AM Hugo Yèche @.***> wrote:

Thanks a lot Emma !

— Reply to this email directly, view it on GitHub https://github.com/ratschlab/HIRID-ICU-Benchmark/pull/22#issuecomment-1234314083, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARKUGG74JPAVXYLRZYR3L3V4CYN3ANCNFSM57A3AA4Q . You are receiving this because you authored the thread.Message ID: @.***>