Closed adamant-pwn closed 6 months ago
Apparently, https://github.com/ratschlab/metagraph/blob/580bae690d98e4c912d73f64a0de76379ddc7633/metagraph/src/common/utils/simd_utils.hpp#L88-L97 stops compiling after https://github.com/simd-everywhere/simde-no-tests/commit/02c7a67ed825018f9efdf2a7e4f39d8196f65337 with the following error:
/home/runner/work/metagraph/metagraph/metagraph/src/common/utils/simd_utils.hpp: In function ‘__vector(4) long int restrict_to_mask_epi64(const uint64_t*, size_t, __vector(4) long int)’:
/home/runner/work/metagraph/metagraph/metagraph/src/common/utils/simd_utils.hpp:88:117: error: AVX vector return without AVX enabled changes the ABI [-Werror=psabi]
88 | SIMDE_FUNCTION_ATTRIBUTES simde__m256i restrict_to_mask_epi64(const uint64_t *hashes, size_t size, simde__m256i mask) {
| ^
To be more specific, it seems to be this change.
At the same time, without updating simde-no-tests
beyond this point, current MacOS build fails with:
In file included from /Users/runner/work/metagraph/metagraph/metagraph/src/common/utils/simd_utils.hpp:4:
In file included from /Users/runner/work/metagraph/metagraph/metagraph/external-libraries/simde-no-tests/x86/avx2.h:33:
In file included from /Users/runner/work/metagraph/metagraph/metagraph/external-libraries/simde-no-tests/x86/avx.h:32:
In file included from /Users/runner/work/metagraph/metagraph/metagraph/external-libraries/simde-no-tests/x86/sse4.2.h:31:
/Users/runner/work/metagraph/metagraph/metagraph/external-libraries/simde-no-tests/x86/sse4.1.h:2232:17: error: use of bitwise '|' with boolean operands [-Werror,-Wbitwise-instead-of-logical]
return !( !(vgetq_lane_s64(s641, 0) | vgetq_lane_s64(s641, 1)) \
~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/runner/work/metagraph/metagraph/metagraph/external-libraries/simde-no-tests/x86/sse4.1.h:2232:17: note: cast one or both operands to int to silence this warning
1 error generated.
make[3]: *** [CMakeFiles/metagraph-core.dir/src/graph/alignment/aligner_extender_methods.cpp.o] Error 1
MacOS workflows currently produce the following error. The PR is a quick dirty fix to it.