ratson / cordova-plugin-admob-free

New development has been moved to "admob-plus-cordova", https://github.com/admob-plus/admob-plus/tree/master/packages/cordova
https://github.com/admob-plus/admob-plus
MIT License
495 stars 210 forks source link

isTesting Reward Ads are live ads #105

Open JohnScottMcNerney opened 7 years ago

JohnScottMcNerney commented 7 years ago

I seem to be seeing live Reward Ads when in test mode (isTesting=true).

I can't be 100% sure, because I don't know what to expect, but they all seem real (mostly game apps). I would expect a test-mode video that says "this is a test mode video".

I do not want to click on one to test this out, because that's supposed to be a big "no-no".

Code is basically a copy/paste of the example. Works great, but this content is concerning.

ratson commented 6 years ago

@JohnScottMcNerney It is not suppose to be (there is an opposite issue https://github.com/ratson/cordova-plugin-admob-free/issues/103), would you create a repo with the code?

bflopez commented 6 years ago

@ratson This is happening to me. Been using your plugin for awhile. Just started working on a new app and saw a Live Ad with the "Test Ad" button over it. Figured it was the new "Testing" until I saw this issue. Clicked the ad and it took me over to the App Store to install Uber. Pretty sure something is wrong. When I turn isTesting to false it shows the same ads but with no "Test Ad" button over it.

I am using Ionic and I know you have mentioned that you don't use it. Could be related to ionic. I noticed it is also happening on iPhone Simulators if you have a Macbook with Xcode. The first time you boot up the simulator it shows the traditional test ad. If you build and run the app again it shows the live ad with the "Test Ad" button over it. I am guessing this happens on real devices too? Hard to tell.

bflopez commented 6 years ago

If anyone comes across this. Admob updated their code so that test ads will look like a real ads when testing on our phone. That is how this plugin is set up at least. As long as the label "Test Ad" is over the ad it is indeed a test ad. It used to be it showed the graphic indicating it was a test ad because it was pulling from Google's Test account. I believe this is correct after reading: https://developers.google.com/admob/ios/test-ads#enable_test_devices

hsnkazmi commented 6 years ago

plz give me working example of reward video in ionic 3