ratson / cordova-plugin-admob-free

New development has been moved to "admob-plus-cordova", https://github.com/admob-plus/admob-plus/tree/master/packages/cordova
https://github.com/admob-plus/admob-plus
MIT License
499 stars 214 forks source link

FUND THIS PROJECT #161

Open ratson opened 6 years ago

ratson commented 6 years ago

As state in README, this plugin is focusing on experience on Android, and it is not my best interest to support different use cases, I was hoping the community could help each other and more PRs are sent, clearly it did not work very well, this results in growing number of open issues. I would like to change the situation, I am wondering if there will be any financial support from the community.

Here are the list of possible improvements,

  1. Better Ionic support, potentially rewrite with TypeScript for good integration
  2. Improve documentation for different use cases
  3. A diagnostic tool / guide
  4. Potentially rewrite iOS code in Swift, testing will be limited to simulator unless the funding is sufficient enough to buy a testing iOS device.
  5. Find better way to handle promise polyfill
  6. Integrate CI

Please comment on this issue if you would financial support this project, the preferred way and which/any further improvements you would like to see.

MBuchalik commented 6 years ago

I have only been using your plugin for a week or so. My problem with adding and testing some small changes is: You cannot directly install this plugin from git. I like using PhoneGap Build for testing on real devices. This leads to problems if you actually have to call npm install before you can build the app. I don't know how many users of your plugin have the same problem (maybe it's just me) but this is the first plugin I have seen so far that can't be installed from a git repo.

I was adding some smaller changes to add basic support for the iPhone X. But to make sure it doesn't break anything, I wanted to test it on my real iPad as well (to see if the banner still remains at the bottom here 😄). In my case, I usually do this though PGB. Also, for testing in the simulator, I'd like to be able to directly fetch the code from my repo. So that's another improvement that could be made.

Oh, maybe you should add a link to this issue in the readme? Don't know how many users scroll through the issues page 😃

One question about your list: What could (3.) A diagnostic tool look like? I can't really imagine what can be tested with a tool here.

Still: As far as I can see, I really like this plugin. Especially the fact that there is no remote controlling of my app ^^

bflopez commented 6 years ago

With this being an "Ionic Native" plugin, does Ionic offer any type of support? I would be willing to pay to use this plugin. I just need a simple up to date version really. Are you looking for subscription or more of a fund raiser? Would a Kickstarter project help?

bflopez commented 6 years ago

@ratson I was hoping more people would have commented on this by now... Have you made a decision what you are going to do? I would be willing to pay a reasonable monthly fee for you to make a paid version. Maybe if enough people paid this fee it would be worth it for you to work on? I know this project started because the lack of honesty in some of the other admob-plugins, one in particular with a "free" version and a paid version but can see now how it might have happened.

erperejildo commented 6 years ago

Honestly I think no one is going to fund this project existing a paid version, but good luck anyway. I can help with some code, I don't mind, and also with a lot of testing and managing here some issues.

Has @bflopez commented I think we should get some help from Ionic. They also encourage people to use this version instead the other one (https://ionicframework.com/docs/native/admob-pro/)

aabdolla commented 6 years ago

I just tried out the admob-pro version tonight and loading a banner ad is brutal to the FPS. I show an ad on start up and it would be a terrible experience if I continued to use the pro version with the hit to performance. I am hoping to use this but currently running into iPhone X issues.

MBuchalik commented 6 years ago

@aabdolla Personally, I would be really careful with the admob-pro plugin. It seems like the author is taking a few percent of your revenue.

aabdolla commented 6 years ago

@MBuchalik Oh really? Even if you pay for the license?

MBuchalik commented 6 years ago

@aabdolla I didn't know you are using a paid license. I am not using this plugin so I can't tell you if paying for a license will remove the ad sharing in all cases. That's something you should ask the author. (As far as I can see, the issues page was removed so it looks like you can't really ask questions there... Maybe, there is some sort of forum where you can ask this question...) Anyways, using cordova-plugin-admob-free should be a "safe" alternative if it's working with your configuration. Also, we probably shouldn't discuss that question in this issue 😄

ratson commented 6 years ago

@aabdolla @MBuchalik Thank you for bring up the issue, I did not realize the links are broken, just updated the README to document what was there.

SharkyPT commented 6 years ago

@ratson , This appears to be a great plugin but unfortunately I'm not able to make it working using phonegap and iOS (did not test Android yet). I agree with you and It would be great if someone could add the steps for this in phonegap. I use the Phonegap App on iOS to test before building and I have several plugins working in my app, but i cannot put this one to work, even with a blank App and your example.

One aspect that you could also add is the donate button or a contribution fee .

Screeze commented 6 years ago

So, currently I am using the admob pro plugin. But as the author closed the issues page I lost confidence in the trustability of it, also seeing some random issues with it sometimes, so I was hoping I could switch to this plugin here. Honestly, I am currently only investing money into my apps, not getting any relevant revenue (yet). But as soon as I am able to make some money with it, I would be willing (and always had that plan) to regularly donate a small percentage for core plugins like this one.

edit: I suggest you link to this issue on top of your readme file, as its buried on page 2 or 3 in the issues section....

lolaswift commented 5 years ago

I will be more than happy to pay for a quality plugin if I can make it work for my app. I have an old ionic 1.x app. Still struggling with getting the plugin work. I am sure I will use your plugin in my new APP and I will be happy to pay for it as well

lolaswift commented 5 years ago

I suggest whoever uses this plugin in production should support the work of the maintainers financially. I am not using it yet but I will be the first one to donate. where is the donate button @ratson

erperejildo commented 5 years ago

Sorry, but it's funny that being the first option on internet to monetise our apps you're not making money with this. The irony...

The other option one that you have to pay for which has worst performance and is taking some percentage from your ads. So this is fight already won for you.

We're too many devs and we can't fix the issues that we have. Can't really understand what is stopping us to get this working.

Can we make a list with what we need and take some actions?

According to this: https://www.npmjs.com/package/cordova-plugin-admob-free your library has been downloaded 852 times just on one week. Let's say that everyone downloaded it 3 times. That makes a total of 284 people on just one week or 1136 a month.

$1 donated for every dev, just $1 (it could be maybe $5 for example) you could earn $1136 a month... just saying.

lolaswift commented 5 years ago

@ratson Just want to confirm that I'm gonna be using it in production and now I am more than happy to donate. Please let me know how I can donate and how much you'd expect. And I want to thank you and thank all the other developers who help to make this plugin.

ratson commented 5 years ago

@lolaswift @erperejildo Thank you for the kind words and encouragement.

According to this: https://www.npmjs.com/package/cordova-plugin-admob-free your library has been downloaded 852 times just on one week. Let's say that everyone downloaded it 3 times. That makes a total of 284 people on just one week or 1136 a month.

$1 donated for every dev, just $1 (it could be maybe $5 for example) you could earn $1136 a month... just saying.

It is a very optimistic estimation. I added the Github issue template few months ago, asking every issue opener to give feedback to this issue. As you see the result, just few of you are here.

But anyway, I am going to spend the next few weeks to come up something.

lolaswift commented 5 years ago

@ratson I think you are asking in the wrong place. I suggest putting the information in the Readme and make it noticeable. To be honest, I almost missed that link. I believe lots of people just didn't bother opening that link. Thousands of people have paid for Admob pro because there wasn't any other good choice. The advantages of this plugin are no Ad sharing and no remote control. Lots of people might not mind paying but most people think remote control is not acceptable. Especially,here in the Europe, we have strict privacy law. To be honest, the quality of Admob pro is really good and I liked it so much and I was willing to pay even more than he asked. I Emailed him about my concern but he didn't bother to answer. Anyway, my advice would be focusing on improving the plugin, do it from your heart and make it the no 1. in the market. Your hardwork will be paid off. And I agree with someone mentioned above, try to work with ionic and get some support as well.

Screeze commented 5 years ago

Totally agree with @lolaswift. I am sure people will be willing to pay for a high quality plugin directly related to their income. Additionally, the admob pro plugin is calling home and blocking app start of my ionic app by several seconds (trying it in airplane mode, the delay is gone!) But this plugin here looks not stable enough to me right now from what I can see in the issues, so I have admob pro with high quality but unacceptable issues (privacy, blocking app start) integrated but I would love to switch away from it. Additionally, Admob Pro disabled the issues section since months which seems VERY dubious to me...

Idea: Why don't you start a kickstarter campaign to get some initial financial boost and then ask prominently for donations? I think ionic would be willing to push this kickstarter campaign over their social media channels giving it a boost.

ratson commented 5 years ago

For those follow my Github activity closely, may have discover that I have been working very hard on admob-plus (apparently no one is following as the project has still zero stars).

I finally have setup a funding page, this is the first time I create it for myself, may not work as expected. Now is waiting the first brave sponsor to verify it works. Feedback and suggestions are welcome.

Functions for Interstitial Ad is complete, but missing docs, it should be ready to try out by the end of this week. Please open issue for the features you are using, which will help me prioritise what to work on next.

erperejildo commented 5 years ago

Awesome @ratson!

What's the main difference from the actual repo? Also I think it would be nice if you had a donate button also, not only subscription option. Both with open donations.

ratson commented 5 years ago

@erperejildo Pretty much everything said in the top of this issue, you may also read here for details.

erperejildo commented 5 years ago

"which is also fork from cordova-plugin-admob" That's the pro version, right? Wouldn't you have any problem with the other user?

Sounds good. I'm pretty sure you will make money with it but more importantly you will be able to dedicate it more time.

Don't forget as soon as you have a testable version get in touch with Ionic team to update their documentation.

Screeze commented 5 years ago

I would also prefer to see a one-time donation button on the funding page. Doesn't mean I would not donate multiple times, but then someone can donate based on their current apps success dynamically.

ratson commented 5 years ago

"which is also fork from cordova-plugin-admob" That's the pro version, right? Wouldn't you have any problem with the other user?

@erperejildo You may read https://admob-plus.github.io/blog/2018/07/15/history-of-cordova-plugin-admob-free.html for the answer.

@Screeze I have explained the rationale in the FAQ. Do you still think I should add a open donation button after reading it?