search

ratson / cordova-plugin-admob-free

New development has been moved to "admob-plus-cordova", https://github.com/admob-plus/admob-plus/tree/master/packages/cordova
https://github.com/admob-plus/admob-plus
MIT License
498 stars 214 forks source link

(android) added bannerHeight to banner LOAD event (#361) #373

Open syonip opened 4 years ago

syonip commented 4 years ago

Same change implemented on android

syonip commented 4 years ago

Hi, any progress on this?

pipboy9000 commented 4 years ago

please merge this fix!! it's extremely helpful!

123dma commented 4 years ago

please merge.. I need it

aabdolla commented 4 years ago

What does it help with?

pipboy9000 commented 4 years ago

having the height in the LOAD event is very useful since the height varies, it saves doing unnecessary calculations for the layout after the the banner is loaded

luigi37 commented 4 years ago

Hi, needed also here. I have a jquery cordova app that needs to be properly resized and if banner is shown I loose bottom buttons...

junbonglee commented 4 years ago

Any progress on this?

f18nfz commented 3 years ago

Just noticed if I test on a device running API 30 or API R the banner height that gets returned is actually the device height (so in this case 14400) - is it just me or are others seeing the same issue? Any ideas?

loadUrl(javascript:cordova.fireDocumentEvent('admob.banner.events.LOAD',{"bannerHeight":14400});)