ratson / cordova-plugin-admob-free

New development has been moved to "admob-plus-cordova", https://github.com/admob-plus/admob-plus/tree/master/packages/cordova
https://github.com/admob-plus/admob-plus
MIT License
499 stars 214 forks source link

v0.6 (New APIs) #40

Closed ratson closed 7 years ago

ratson commented 7 years ago

This release includes reward video support, new set of APIs and emit events with namespace.

Before releasing it, I would like to make sure it is fully backward-compatible, so people could upgrade smoothly.

@vintage @warcry2000 @becvert @code4youreal Would you try this out and let me know if it breaks your code?

Close #7, #16, #37, #38, #39, #41.

warcry2000 commented 7 years ago

Hi, I have not been able to try these days. Between today and tomorrow I try to do the tests. Thanks

ratson commented 7 years ago

Never mind, I am still polishing the docs, let me know if you find anything is not clear.

warcry2000 commented 7 years ago

@ratson I installed the plugin: when I do: cordova build android Give me the following error:

Error: cmd: Command failed with exit code 1 Error output.... android\src\name\ratson\cordova\admob\banner\BannerListener.java:52: error: cannot find symbol executor.fireadevent("admob.banner.event.LOAD", data); symbol: variable data location: class BannerListener

regards

swaraasolutions commented 7 years ago

Any ideas when you are merging this pull request ios is not working currently and not showing any banner google works fine though i have been using phonegap build and keep on getting errors related to sdk about deprecated function for init etc.

ratson commented 7 years ago

@warcry2000 Fixed the error

@swaraasolutions Would you paste the error for reference? Some deprecated functions may still be using by cordova / phonegap for backward compatibility.

swaraasolutions commented 7 years ago

Sure i can paste the error in sometime also does it make any difference if i am using Ionic?

warcry2000 commented 7 years ago

@ratson In android, without touching any code, my application works correctly, both banner and interstitial In IOS I try tomorrow.

¿Do you have an example of how to use the new api? To go testing too.

ratson commented 7 years ago

The example is updated to use new APIs, you can browse it at https://github.com/ratson/cordova-plugin-admob-free/blob/next/example/www/js/index.js

warcry2000 commented 7 years ago

@ratson In IOS, without touching any code, my application works correctly, both banner and interstitial.

Now I will modify the code with the new api, with banner, interstitial and video, I prove it and I will report the conclusions.

warcry2000 commented 7 years ago

@ratson The tests carried out with the New API are: Android:

IOS:

Old API: Android:

IOS:

Script47 commented 7 years ago

Is this safe to use? Meaning has it been tested?

becvert commented 7 years ago

It's good to me. I'm only using interstitials though. Thanks