search

ratson / puppeteer_plus

Deno port of puppeteer base on latest TypeScript source.
https://deno.land/x/puppeteer_plus
MIT License
20 stars 4 forks source link

fix #2 #3

Closed jerrygreen closed 1 year ago

jerrygreen commented 2 years ago

I have found, around the project, that you're importing from https://deno.land/std@0.151.0/node/stream.ts:

https://github.com/ratson/puppeteer_plus/blob/68223f46614434d2f089068e07c5b9ace05e52ba/vendor/puppeteer/src/common/Page.ts#L18

https://github.com/ratson/puppeteer_plus/blob/68223f46614434d2f089068e07c5b9ace05e52ba/vendor/puppeteer/src/common/util.ts#L18

But those are static imports. There's one dynamic import that wasn't transformed:

https://github.com/ratson/puppeteer_plus/blob/68223f46614434d2f089068e07c5b9ace05e52ba/vendor/puppeteer/src/common/util.ts#L487

So this is a fix.

jerrygreen commented 2 years ago

BY THE WAY, it is not sufficient to make work await page.pdf({ path: 'file.pdf' }), but it is a little step towards it.

There is another issue before it will be possible to convert to pdf: https://github.com/ratson/puppeteer_plus/issues/4

ratson commented 1 year ago

@jerrygreen Thank you for the PR. the latest version import upstream directly, it should address this issue. The vendor directory will soon be removed.

ratson commented 1 year ago

@jerrygreen Fixed in v0.18.0.

Fix #2 Fix #4