ratt-ru / CubiCal

A fast radio interferometric calibration suite.
GNU General Public License v2.0
18 stars 13 forks source link

lsm-based parallactic angle is the wrong way around #255

Open bennahugo opened 5 years ago

bennahugo commented 5 years ago

According to @sjperkins the P matrix is rotating the same direction as MT cattery. This is the wrong way around, see ska-sa/meqtrees-cattery#96, and the opposite of what is implemented in parallactic machine rotating MODEL_DATA.

o-smirnov commented 5 years ago

Careful, there's three different places in Cattery where to rotation comes in -- which one are you comparing to?

bennahugo commented 5 years ago

See @bmerry's description on cattery it needs to be flipped in both simulator and stefcal

o-smirnov commented 5 years ago

Let's not jump the gun yet. I'd like to establish exactly which Cattery term @sjperkins compared to. P-Jones might be the wrong way around, but L-Jones seems correct. Anyway we can check this with the VLA polcal experiment...