search

ratt-ru / CubiCal

A fast radio interferometric calibration suite.
GNU General Public License v2.0
18 stars 13 forks source link

Apply gains to autocorrelations when forming corrected data/residuals. #437

Closed JSKenyon closed 3 years ago

JSKenyon commented 3 years ago

@bennahugo could you please test drive this? I have sanity checked it locally, but you may want to confirm that it is producing what you expect.

JSKenyon commented 3 years ago

retest this please

JSKenyon commented 3 years ago

Tests cannot pass at present. See this SO. I know we decided that python2.7 needed to burn, so should we remove that part of the tests?

o-smirnov commented 3 years ago

Yeah we were already going to drop it in https://github.com/ratt-ru/CubiCal/pull/424 anyway. Which, BTW, really ought to get merged now. But let's do this one first!

bennahugo commented 3 years ago

Sure I will try it next week - a bit swamped monitoring the current science observations. Thanks Jon.

On Fri, 26 Feb 2021, 12:29 Oleg Smirnov, notifications@github.com wrote:

Yeah we were already going to drop it in #424 https://github.com/ratt-ru/CubiCal/pull/424 anyway. Which, BTW, really ought to get merged now. But let's do this one first!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ratt-ru/CubiCal/pull/437#issuecomment-786559409, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4RE6T2T2ES7XWBMQ5LEZ3TA5ZYPANCNFSM4YIAVW4A .

bennahugo commented 3 years ago

As discussed this removes the OMT response but neither the Tsys contribution from Tlna or Tspil which are both correlated powers that are frequency dependent on these products @landmanbester. I don't see a reason not to at least remove the OMT response from them though? The other Tsys factors have to be determined by other means - ie on/off observation or another more complicated mechanism to block off the power from the horn in switching systems - these are in very old telescopes, but I don't know if they are actually still in use anywhere.