ratt-ru / CubiCal

A fast radio interferometric calibration suite.
GNU General Public License v2.0
18 stars 13 forks source link

add option to bomb out when null model is detected #438

Open o-smirnov opened 3 years ago

o-smirnov commented 3 years ago

Model columns can't be null. They're only null when (a) https://github.com/casacore/python-casacore/issues/130 has its teeth in you, or (b) WSClean/DDFacet did not fill in the model properly (possibly because you had too many flags on the MS when predicting).

Both cases are Very Bad News actually, so I think the red warning should be upgraded to an exception.

(Or maybe add a parset option to throw an exception or not? Default being to throw.)

cyriltasse commented 3 years ago

or (c) when the sky itself is empty... :))

o-smirnov commented 3 years ago

or (c) when the sky itself is empty... :))

Which is also an excellent reason to stop calibrating!