search

ratt-ru / CubiCal

A fast radio interferometric calibration suite.
GNU General Public License v2.0
18 stars 13 forks source link

Why not in pypi? #445

Closed gijzelaerr closed 2 years ago

gijzelaerr commented 3 years ago

Why is cubical not in pypi? makes it easier to install.

I've taken the liberty to upload the latest version, but that fails:

HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
Invalid value for requires_dist. Error: Can't have direct dependency: "montblanc @ git+https://github.com/ska-sa/montblanc.git@0.6.1 ; extra == 'lsm-support'"

Montblanc is actually on pypi, but not version 0.6.1. Any reason why 0.6.1 specifically is required, or can we just upgrade.

o-smirnov commented 3 years ago

Tender triggering tremours of tensorflow here, or maybe I've had too much coffee.

gijzelaerr commented 3 years ago

that caused by an optional dependency on Montblanc, but that doesn't mean it can't be uploaded to pypi.

made a little pr:

https://github.com/ratt-ru/CubiCal/pull/446

and uploaded it also:

https://pypi.org/project/cubical/

JSKenyon commented 3 years ago

There used to be more reasons why we weren't on PyPI - Montblanc is the final sticking point. It is technically end of life now, but if @sjperkins is feeling charitable, maybe he can help us out.

JSKenyon commented 3 years ago

@gijzelaerr Could you please make me a maintainer of CubiCal on PyPI? Unless you are ok with me prodding you to do version uploads.

I guess we could automate it to happen on release, though I have never done that.

bennahugo commented 3 years ago

That is quite trivial to do. All you need is to store the secret token in github secrets and add a github action

e.g. https://github.com/ska-sa/meqtrees-cattery/blob/master/.github/workflows/python-publish.yml

gijzelaerr commented 3 years ago

what is your pypi username

JSKenyon commented 3 years ago

JSKenyon

gijzelaerr commented 3 years ago

you received an invitation

Op di 23 mrt. 2021 om 11:31 schreef JSKenyon @.***>:

JSKenyon

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ratt-ru/CubiCal/issues/445#issuecomment-804753450, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPVJD26KTOPK256H22NEDTFBNUBANCNFSM4ZE4D36A .

-- Gijs Molenaar http://pythonic.nl

JSKenyon commented 3 years ago

Thanks! Accepted.

bennahugo commented 2 years ago

I believe this is resolved since