Reinstate support for single correlation measurement sets.

[JSKenyon]

What it says on the label. Use at your own risk as things may break. @o-smirnov I distinctly remember writing the code to handle single correlation measurement sets inside _column_to_cube but it seems at some point we disabled it at a higher level. Any idea why? This runs through on my test data using both the predict and a model column. Predict may be a bit dodgy if the field has polarisation, but this is not going to be a mainstream mode. @KshitijT feel free to give this a shot.

[KshitijT]

Thanks @JSKenyon !

[bennahugo]

hmm I don't think I support this case in my facet based predictor, so cannot guarantee that will work

On Tue, Aug 10, 2021 at 2:44 PM Oleg Smirnov @.***> wrote:

@.**** approved this pull request.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ratt-ru/CubiCal/pull/449#pullrequestreview-726385343, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4RE6TF5QFHMDCVN5JURY3T4ENJRANCNFSM44JHFM2A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

--

Benjamin Hugo

PhD. student, Centre for Radio Astronomy Techniques and Technologies Department of Physics and Electronics Rhodes University

Junior software developer Radio Astronomy Research Group South African Radio Astronomy Observatory Black River Business Park Observatory Cape Town

[o-smirnov]

Put a big red error message in there and leave it at that? Facet-based predict + single-corr MSs is a very obscure corner of the parameter space which I'm not too worried about overlooking...

[bennahugo]

hmm it looks like I may have anticipated this, but I've never tested it I assume that the model shape in the cube is either 1, 2 or 4 dimensional. I don't think I've ever tested this for anything other than 2x2 though - I no longer split off my crosspols, so use at your own risk. https://github.com/ratt-ru/CubiCal/blob/master/cubical/degridder/DDFacetSim.py#L592

On Tue, Aug 10, 2021 at 2:57 PM Oleg Smirnov @.***> wrote:

Put a big red error message in there and leave it at that? Facet-based predict + single-corr MSs is a very obscure corner of the parameter space which I'm not too worried about overlooking...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ratt-ru/CubiCal/pull/449#issuecomment-896005071, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4RE6QHKXQE4O26CVJ6H7DT4EO4XANCNFSM44JHFM2A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

--

Benjamin Hugo

PhD. student, Centre for Radio Astronomy Techniques and Technologies Department of Physics and Electronics Rhodes University

Junior software developer Radio Astronomy Research Group South African Radio Astronomy Observatory Black River Business Park Observatory Cape Town

[JSKenyon]

This was never going to be merged until someone played around with it. Perfectly happy for it to remain as a PR until someone battle-tests it as this is not a very common use-case.

[bennahugo]

@KshitijT can you confirm that this works so I can push a release with it (or without it)?