ratt-ru / QuartiCal

CubiCal, but with greater power.
MIT License
8 stars 4 forks source link

Revise parameter arrays #124

Closed JSKenyon closed 3 years ago

JSKenyon commented 3 years ago

This is the first step towards simplifying the parameterised solvers. Previously, parameters were stored in a (time, chan, ant, dir, param_per_corr, corr) array. This was not necessarily bad, but was increasing code complexity in the solvers as the mathematics results in a vector of parameter values. As such, parameters are now stored in in a (time, chan, ant, dir, param) array. This simplifies code in the solver (I was able to delete and unify dispatch in several places). Currently, these flattened parameter arrays are written to disk with appropriate labels e.g. delay_XX or phase_LL. We could also reshape them if it becomes necessary.