ratt-ru / QuartiCal

CubiCal, but with greater power.
MIT License
8 stars 4 forks source link

Python 3.10 tests currently failing #174

Closed JSKenyon closed 2 years ago

JSKenyon commented 2 years ago

Describe the bug Tests fail on Python 3.10 due to a binary incompatibility between the numpy version required by numba (currently < 1.23) and the numpy version used to build python-casacore. This cannot be resolved without a version of python-casacore which works with numpy < 1.23 or a version of numba which supports numpy>=1.23. Waiting for a numba release is the simpler approach but way take a few months.

To Reproduce Simply run the tests under Python 3.10.

Expected behavior QuartiCal should work under Python 3.10.

bennahugo commented 2 years ago

Use --no-binary ':python-casacore:' to force casacore to build against an older version of numpy. You'd need casacore on the system though.

On Mon, Jul 18, 2022 at 12:57 PM JSKenyon @.***> wrote:

Describe the bug Tests fail on Python 3.10 due to a binary incompatibility between the numpy version required by numba (currently < 1.23) and the numpy version used to build python-casacore. This cannot be resolved without a version of python-casacore which works with numpy < 1.23 or a version of numba which supports numpy>=1.23. Waiting for a numba release is the simpler approach but way take a few months.

To Reproduce Simply run the tests under Python 3.10.

Expected behavior QuartiCal should work under Python 3.10.

— Reply to this email directly, view it on GitHub https://github.com/ratt-ru/QuartiCal/issues/174, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4RE6WB42NNMYKUUPV5XQLVUU2CRANCNFSM5332JUQQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

Benjamin Hugo

PhD. student, Centre for Radio Astronomy Techniques and Technologies Department of Physics and Electronics Rhodes University

Junior software developer Radio Astronomy Research Group South African Radio Astronomy Observatory Black River Business Park Observatory Cape Town

JSKenyon commented 2 years ago

Running:

pip install --no-binary "python-casacore" python-casacore

gives:

/usr/bin/ld: cannot find -lboost_python-py310-mt

Presumably this is a a libboost dependency but I am not sure what to install to satisfy it @bennahugo.

bennahugo commented 2 years ago

Yea you will probably need a reasonably new boost installed on the system

On Mon, 18 Jul 2022, 14:30 JSKenyon, @.***> wrote:

Running:

pip install --no-binary "python-casacore" python-casacore

gives:

/usr/bin/ld: cannot find -lboost_python-py310-mt

Presumably this is a a libboost dependency but I am not sure what to install to satisfy it @bennahugo https://github.com/bennahugo.

— Reply to this email directly, view it on GitHub https://github.com/ratt-ru/QuartiCal/issues/174#issuecomment-1187288368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4RE6WJ35KVJVE5HNJ7HLLVUVE65ANCNFSM5332JUQQ . You are receiving this because you were mentioned.Message ID: @.***>

JSKenyon commented 2 years ago

This is on 20.04. I still think I am justified in whining as this basically renders QuartiCal uninstallable under Python 3.10 without fiddling. I suspect that 20.04 doesn't have a sufficiently recent boost and installing that manually doesn't really resolve the issue. I have opened https://github.com/casacore/python-casacore/issues/235 as I believe that there should either be a final python-casacore 3.4 release which supports Python 3.10 or the python-casacore 3.5 release should work with the first version of numpy to support Python 3.10 (Numpy version 1.22.0).

JSKenyon commented 2 years ago

This has been fixed upstream.

bennahugo commented 2 years ago

Yup agreed.

Boost is only bundled for the python that is natively bundled with your version - here 3.8 in other words.

It may help to upgrade to Ubuntu 22.04 which ships 3.10 as the default

On Mon, 18 Jul 2022, 14:39 JSKenyon, @.***> wrote:

This is on 20.04. I still think I am justified in whining as this basically renders QuartiCal uninstallable under Python 3.10 without fiddling. I suspect that 20.04 doesn't have a sufficiently recent boost and installing that manually doesn't really resolve the issue. I have opened casacore/python-casacore#235 https://github.com/casacore/python-casacore/issues/235 as I believe that there should either be a final 3.4 release which supports 3.10 or the 3.5 release should work with the first version of numpy to support Python 3.10.

— Reply to this email directly, view it on GitHub https://github.com/ratt-ru/QuartiCal/issues/174#issuecomment-1187308872, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4RE6UE7SQZTR25ONBUDR3VUVF7VANCNFSM5332JUQQ . You are receiving this because you were mentioned.Message ID: @.***>