Describe the problem that the feature should address
Users may not realise that direction-dependent gain terms need to be explicitly set as such via (term).direction_dependent.
Describe the solution you'd like
If the model contains multiple directions but no direction-dependent terms are present, QC should error out. However, as it is sometimes convenient to use a model with multiple directions even when solving for direction-independent gains (for purposes of source subtraction), there should be a flag e.g. input_model.require_dd_term which will default to True.
Describe alternatives you've considered
Another approach may be to avoid adding more parameters to QC and instead print a large, red warning when the user has specified a model with multiple directions but not enabled a direction-dependent gain term. This will not cause an error but it is one less setting for users to get wrong.
JSKenyon
commented
1 year ago
Describe the problem that the feature should address Users may not realise that direction-dependent gain terms need to be explicitly set as such via
(term).direction_dependent.Describe the solution you'd like If the model contains multiple directions but no direction-dependent terms are present, QC should error out. However, as it is sometimes convenient to use a model with multiple directions even when solving for direction-independent gains (for purposes of source subtraction), there should be a flag e.g.
input_model.require_dd_termwhich will default toTrue.Describe alternatives you've considered Another approach may be to avoid adding more parameters to QC and instead print a large, red warning when the user has specified a model with multiple directions but not enabled a direction-dependent gain term. This will not cause an error but it is one less setting for users to get wrong.